Better documentation for wrap-character #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This wasn't introduced in 3.0.20 right? So the change should also go into the other API files. |
|
Yes. But the question is: When was this feature introduces? The api documentation starts with version 2.0, but I guess the current behaviour based on ICU was introduced in a commit in 2014 which might mean that it is present since version 3.0. Is this correct? |
Yes, you are correct, the documentation is valid for all 3.0 versions of Mapnik. |
|
PR updated. Ready. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation as proposed in mapnik/mapnik#3885 (comment)